update to go1.23 in main
#35697
Merged
update to go1.23 in main
#35697
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Among other minor updates, we also have #35426 pending use of the new range over functions feature. |
jbardin
force-pushed
the
jbardin/update-go
branch
from
0bd6aa2 to
17d5480
Compare
jbardin
force-pushed
the
jbardin/update-go
branch
from
fd6c760 to
7b80638
Compare
|
I'm also doing concurrent work in the nested backend modules which will conflict here, but will rebase before merging. |
jbardin
force-pushed
the
jbardin/update-go
branch
from
4c56198 to
2131e28
Compare
Release notes: https://go.dev/doc/go1.23
Make sure tooling dependencies are updated to use go1.23, and get any closely related package updates, like golang.org/x/*
Some updates to staticcheck were catching more errors. Most of these were format functions without a format string, but rather than adding more exceptions I just fixed them all. This did also catch some incorrectly wrapped errors.
jbardin
force-pushed
the
jbardin/update-go
branch
from
2131e28 to
9ff7274
Compare
liamcervante
approved these changes
Sep 12, 2024
|
Reminder for the merging maintainer: if this is a user-visible change, please update the changelog on the appropriate release branch. |
|
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Release notes: https://go.dev/doc/go1.23
Code changes were because some updates to staticcheck were catching more errors. Most of these were format functions without a format string, but rather than adding more exceptions I just fixed them all. This did also catch some incorrectly wrapped errors however.